Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios, podspec): depend on React-Core instead of React #4275

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix(ios, podspec): depend on React-Core instead of React #4275

merged 1 commit into from
Sep 17, 2020

Conversation

mrousavy
Copy link
Contributor

Description

On Xcode 12 some wild build errors occur when trying to build a React Native app. This is because the 'React' pod is only an umbrella pod. See: facebook/react-native#29633

Related issues

See: facebook/react-native#29633

Release Summary

  • Uses 'React-Core' instead of 'React' pod in podspecs

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes for React < 0.60 (because of autolinking)
    • No

@vercel
Copy link

vercel bot commented Sep 17, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/hj8zxn5cc
✅ Preview: https://react-native-firebase-git-fork-mrousavy-fix-xcode12-build.invertase.vercel.app

mikehardy
mikehardy approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and I appreciate the collaboration over on the related issue since I'm having trouble reproducing it myself.

@mikehardy mikehardy changed the title Podspec: Depend on React-Core instead of React fix(ios, podspec): depend on React-Core instead of React Sep 17, 2020
@mikehardy
Copy link
Collaborator

For anyone else that needs this but is having problem upgrading to current because of for instance #4229 - you may depend on the patches we generate for every PR https://github.com/invertase/react-native-firebase/actions/runs/259924803 - applied via patch-package they can be used in place of updating, as a temporary measure while root causes are resolved

@mikehardy mikehardy merged commit fd1a2be into invertase:master Sep 17, 2020
This was referenced Sep 18, 2020
Closed
Closed
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
@mrousavy
fix(ios, podspec): depend on React-Core instead of React (invertase#4275
23bec01 
)
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
@mrousavy
fix(ios, podspec): depend on React-Core instead of React (invertase#4275
270d714 
)
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
@mrousavy
fix(ios, podspec): depend on React-Core instead of React (invertase#4275
629aa7a 
)
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Sep 15, 2021
@mrousavy
fix(ios, podspec): depend on React-Core instead of React (invertase#4275
631291b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrousavy @mikehardy